Attention is currently required from: Sean Rhodes.
Felix Held has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85714?usp=email )
Change subject: mb/starlabs/starbook: Add Alder Lake-N (N200) variant
......................................................................
Patch Set 24:
(1 comment)
File src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb:
PS24:
shouldn't the 2 type c ports be on the CPU's tcss_xhci controller instead of on the PCH's xhci controller? at least that's what i remember from a half-finished coreboot port for adl-n that i've started some time ago
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85714?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Gerrit-Change-Number: 85714
Gerrit-PatchSet: 24
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Fri, 17 Jan 2025 18:09:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No