Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34754 )
Change subject: soc/intel/cannonlake: Add provision to skip postcar and load ramstage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34754/2/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/34754/2/src/soc/intel/cannonlake/ro... PS2, Line 143: set_var_mtrr(mtrr, base, size, MTRR_TYPE_WRPROT);
Well the stack frame created for postcar would be exactly want you want to apply prior to run_ramsta […]
yes you are right, in fact i have done in that way first but later i saw the code changes was too much/too complicated (where i can't team down CAR, because i'm inside CAR but still wish to program new sets of MTRRs in romstage and later once i have reached ramstage, again doing the tear down and reprogramming those MTRRs) and decided to make most of code re usability from exit_car.S which does the same thing in simplest form using postcar_frame