Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45654 )
Change subject: soc/intel/cannonlake: Make CNL gpio_op.asl unified as TGL ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
LGTM, thank you! Just a few nits in the commit message.
https://review.coreboot.org/c/coreboot/+/45654/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45654/2//COMMIT_MSG@7 PS2, Line 7: Make CNL gpio_op.asl unified as TGL Align gpio_op.asl with TGL
https://review.coreboot.org/c/coreboot/+/45654/2//COMMIT_MSG@9 PS2, Line 9: Also delete unused gpio_common.h from CNL SoC Maybe:
Also drop gpio_common.h in favor of intelblocks/gpio_defs.h macros.
https://review.coreboot.org/c/coreboot/+/45654/2//COMMIT_MSG@14 PS2, Line 14: 'dmesg` nit: use matching quotes? left one is a single quote, right one is a backtick