Attention is currently required from: Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47023 )
Change subject: sb/intel/common: Add AHCI library ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
File src/southbridge/intel/common/ahci.h:
https://review.coreboot.org/c/coreboot/+/47023/comment/bdd32ddd_3a7e4321 PS5, Line 3: #ifndef __SOUTHBRIDGE_INTEL_COMMON_AHCI_H__ besides 0x1c is there anything intel specific here? This should be moved to src/include
https://review.coreboot.org/c/coreboot/+/47023/comment/2e3131b2_ed2650f0 PS5, Line 46: struct { once in src/include/ this and the other structs must also support big endian.
https://review.coreboot.org/c/coreboot/+/47023/comment/4c93f0e7_c026eec6 PS5, Line 118: __SERIAL_ATA_AHCI_H__ header guard doesn't match