Attention is currently required from: Tim Wawrzynczak. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63561 )
Change subject: drivers/i2c/dw_i2c: Adjust to handle 0-byte transfers ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/63561/comment/62699e68_854d9260 PS1, Line 377: if (segments->len == 0)
This implies (count == 1) as well right? should it be checked?
not necessarily - you still need at least 1 segment even with a zero-byte xfer, to define the slave address. I could check for count == 0 here as well, but did it this way to be consistent with the addition below