[coreboot-gerrit] Change in coreboot[master]: commonlib/bsd: Add new CBFS core implementation

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38421 )

Change subject: commonlib/bsd: Add new CBFS core implementation
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_pri... 
File src/commonlib/bsd/cbfs_private.c:

https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_pri... 
PS11, Line 75: 				  offset + sizeof(mdata.h), todo) != todo)
> > As long as it doesn't pass the overflowing file entry back out to anywhere, I don't see the differ […]

Right, for Chrome OS specifically, I see no way this could cause a problem that wouldn't immediately be obvious. It's really just backwards-compatibility to edge cases that used to be technically legal but aren't anymore (and cbfstool will make sure not to generate them going forward). I don't think there's a need to put in extra Kconfigs or something, because for Chrome OS we always use the newest cbfstool anyway.