Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48175 )
Change subject: cpu/x86/64bit: Add code to call function in protected mode
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48175/4/src/cpu/x86/64bit/mode_swit...
File src/cpu/x86/64bit/mode_switch.S:
https://review.coreboot.org/c/coreboot/+/48175/4/src/cpu/x86/64bit/mode_swit...
PS4, Line 27: movl -64(%ebp), %edx /* Argument 0 */
: movl -72(%ebp), %ecx /* Argument 1 */
That's intended, see description in the headers. Maybe it even works with a changed function prototype. I'll do some tests.
ok. sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48175
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22af2d224b546c0be9e7295330b4b6602df106d6
Gerrit-Change-Number: 48175
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 01 Dec 2020 18:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment