Attention is currently required from: Bora Guvendik, Anil Kumar K, Subrata Banik, Jeremy Compostella, Jérémy Compostella, Selma Bensaid, Paul Menzel, Angel Pons, Bernardo Perez Priego.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58101 )
Change subject: lib/spd_bin: Update names and definitions for LPDDR5
......................................................................
Patch Set 13:
(1 comment)
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/58101/comment/4ccc2742_d40034d4
PS13, Line 27: use_ddr4_ddr5_params
The function name is changed since it is modified to cover ddr5. […]
yes. agree. this function does not have proper name to reveal what it does at the beginning. This has been pointed out earlier. one way to do is to create use_ddr3_param() instead of using this function and change the logic and printout.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52ecf24a313d4cbdd0859c623533630c6a6c3713
Gerrit-Change-Number: 58101
Gerrit-PatchSet: 13
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Mon, 02 May 2022 22:37:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment