[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/{cml, whl}: Add option to skip HECI function disable in SMM

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33193 )

Change subject: soc/intel/{cml, whl}: Add option to skip HECI function disable in SMM
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/33193/1/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/33193/1/src/soc/intel/cannonlake/Kconfig@30 
PS1, Line 30: CHROMEOS
> I got your point, the reason i have kept this check is that other WHL and CML users apart from chrom […]

Correct. If a board does not want to disable Heci, they can set Heci1Enabled to 1.

BTW does this mean that ICL/CNL do not support disabling of HECI using FSP?

https://review.coreboot.org/#/c/33193/5/src/soc/intel/common/block/smm/Kconf... 
File src/soc/intel/common/block/smm/Kconfig:

https://review.coreboot.org/#/c/33193/5/src/soc/intel/common/block/smm/Kconf... 
PS5, Line 27: SKIP_HECI_FUNCTION_DISABLE_USING_SMM
Does this have to be a negative option? i.e. can it instead be HECI_DISABLE_USING_SMM?