Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45373 )
Change subject: soc/intel/common/block: Do not die if PRMRR size unsupported ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45373/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/45373/1/src/soc/intel/common/block/... PS1, Line 373: BIOS_WARNING
This is more an error than a warning, since programming PRMRR seems to be a *must* (see the check in […]
I wonder if there is any device where we currently hit that die(). that should only happen in an absolute error case, where die() would be right. when PRMRR is not supported by the soc, the code returns at line 357. that means die() can only be hit when the user selects a PRMRR size, that is too small. as of my knowlege, currently there is no soc that wouldn't support any of the settings, except the highest value 256MB, which is only supported by newer socs.