4 Jan
2022
4 Jan
'22
10:55 a.m.
Attention is currently required from: Felix Singer, Andy Pont, Angel Pons, Michael Niewöhner. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60123 )
Change subject: mb/starlabs/labtop: Add comments for GPIO End Points ......................................................................
Patch Set 25:
(1 comment)
This change is ready for review.
File src/mainboard/starlabs/labtop/variants/tgl/gpio.c:
https://review.coreboot.org/c/coreboot/+/60123/comment/8750c8a3_53a046d3 PS19, Line 28: /* GPD0 --[ GPD0 ]-- PCH_BATLOW# */
TBH it's pretty hard to review that due to the line offsets. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60123
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a
Gerrit-Change-Number: 60123
Gerrit-PatchSet: 25
Gerrit-Owner: Sean Rhodes admin@starlabs.systems
Gerrit-Reviewer: Andy Pont andy.pont@sdcsystems.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Andy Pont andy.pont@sdcsystems.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 04 Jan 2022 10:55:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment