Attention is currently required from: Furquan Shaikh, Martin Roth. Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54740
to look at the new patch set (#4).
Change subject: mb/google/guybrush: Move variant_has_fpmcu() after eSPI init ......................................................................
mb/google/guybrush: Move variant_has_fpmcu() after eSPI init
Currently variant_has_fpmcu() is called very early in bootblock, before eSPI is initialized. When checking CBI for its presence, that causes an error and nothing else can be read from CBI in bootblock.
Moving it slightly later in bootblock doesn't hurt anything from a timing standpoint, and allows CBI to be read.
BUG=None TEST=See CBI get read and the FPMCU field read correctly.
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6de44119e92c8820b266f9f07287706c7d4eb505 --- M src/mainboard/google/guybrush/bootblock.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/54740/4