Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42289 )
Change subject: soc/intel/xeon_sp: Enable PMC support
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/42289/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42289/3//COMMIT_MSG@19
PS3, Line 19: select CPU_INTEL_COMMON_SMM
Yes. I will be adding SMI handler in upcoming patches after this patch is approved/merged.
Resolved?
https://review.coreboot.org/c/coreboot/+/42289/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42289/4//COMMIT_MSG@19
PS4, Line 19: select CPU_INTEL_COMMON_SMM
Let's add them to soc/intel/xeon_sp/Kconfig.
Resolved?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d57a8282a8b6dc4314f156c39deb09535575cbd
Gerrit-Change-Number: 42289
Gerrit-PatchSet: 6
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Sep 2020 18:42:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Rocky Phagura
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment