Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39697 )
Change subject: nb/amd/agesa/family14: Improve HTC threshold handling ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39697/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39697/4//COMMIT_MSG@9 PS4, Line 9: According to BKDGs HTC temperature limit field indicates the threshold I think these lines are a bit too long, the commit message looks weird in Gerrit. It should be reflowed:
According to BKDGs HTC temperature limit field indicates the threshold where HTC becomes active. HTC active state means that processor is limiting its power consumption and maximum P-State. Using this threshold as _CRT is incorrect, since HTC active is designed to prevent overheating, not causing immediate shutdown.