David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit ......................................................................
Patch Set 11: Code-Review-1
(3 comments)
Only a few minor comments from me. Otherwise, I think the patch is ready to go?
https://review.coreboot.org/#/c/29470/11/Documentation/mainboard/portwell/pq... File Documentation/mainboard/portwell/pq7-m107.md:
https://review.coreboot.org/#/c/29470/11/Documentation/mainboard/portwell/pq... PS11, Line 94: | Super I/O | None | Should this be "Super I/O, EC", like https://review.coreboot.org/c/coreboot/+/30414/26/Documentation/mainboard/fa... ?
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/fadt.c File src/mainboard/portwell/m107/fadt.c:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/fadt.c@... PS11, Line 31: header->asl_compiler_revision = 1; Is there a reason for setting this to 1? Usually it is set to asl_revision.
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/smihand... File src/mainboard/portwell/m107/smihandler.c:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/smihand... PS11, Line 25: case 0x99: Perhaps we can get rid of this file, same as https://review.coreboot.org/c/coreboot/+/30414/22/src/mainboard/facebook/fbg...