Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42885 )
Change subject: soc/amd/picasso/memlayout: Verify bootblock is 16-bit aligned
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42885/1/src/soc/amd/picasso/memlayo...
File src/soc/amd/picasso/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/42885/1/src/soc/amd/picasso/memlayo...
PS1, Line 84: _ = ASSERT(CONFIG_BOOTBLOCK_ADDR == ((CONFIG_BOOTBLOCK_ADDR + 0xFFFF) & 0xFFFF0000), "Bootblock must be 16 bit aligned");
We should move this to src/cpu/x86/16bit/reset16.inc and mark it aligned to 16 bits.
resolving comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29c244a3f08df46c5992fe81683b9c0d740ff248
Gerrit-Change-Number: 42885
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 30 Jun 2020 21:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment