Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34497 )
Change subject: mb/google/drallion: Add new mainboard
......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34497/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34497/1//COMMIT_MSG@9
PS1, Line 9:
Done
Done
https://review.coreboot.org/c/coreboot/+/34497/1//COMMIT_MSG@9
PS1, Line 9:
Done
Done
https://review.coreboot.org/c/coreboot/+/34497/1//COMMIT_MSG@10
PS1, Line 10: uses the Chrome EC, that will be enabled in a seperate commit
Modified to Wilco EC
Done
https://review.coreboot.org/c/coreboot/+/34497/1//COMMIT_MSG@10
PS1, Line 10: uses the Chrome EC, that will be enabled in a seperate commit
Modified to Wilco EC
Done
https://review.coreboot.org/c/coreboot/+/34497/2/src/mainboard/google/dralli...
File src/mainboard/google/drallion/Kconfig:
https://review.coreboot.org/c/coreboot/+/34497/2/src/mainboard/google/dralli...
PS2, Line 72: "google/drallion
missing "
Done
https://review.coreboot.org/c/coreboot/+/34497/1/src/mainboard/google/dralli...
File src/mainboard/google/drallion/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/34497/1/src/mainboard/google/dralli...
PS1, Line 7: config BOARD_GOOGLE_DRALLION
: bool "-> Drallion"
: select BOARD_GOOGLE_BASEBOARD_DRALLION
Agree, done.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34497
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I541952a4ef337e7277a85f02d25979f12ec075c4
Gerrit-Change-Number: 34497
Gerrit-PatchSet: 5
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Jul 2019 23:52:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment