Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40563 )
Change subject: soc/intel/common: Trigger recovery mode for CSE Lite SKU run time errors ......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 5: <security/vboot/misc.h> nit: Put this below along with security/vboot/vboot_common.h
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 9: #include <vb2_api.h>
since you are using vb2api_fail()
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 43: * Can you also add: (Failure to set next boot partition as RW).
It is a little confusing how CSE_LITE_SKU_RW_JUMP_ERROR and CSE_LITE_SKU_RW_SWITCH_ERROR are different. Above comment might help provide some more info.
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 146: VB2_RECOVERY_INTEL_CSE_LITE_SKU This is going to require an uprev of vboot in coreboot: https://review.coreboot.org/c/coreboot/+/41536
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 150: do_global_reset(); I think we can just add a die("") here. This condition is not really expected.