Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34948 )
Change subject: superio/nuvoton: add a driver for nct668xd
......................................................................
Patch Set 7:
(1 comment)
found a regression I introduced in a patch a year ago while reviewing this patch
https://review.coreboot.org/c/coreboot/+/34948/7/src/superio/nuvoton/nct668x...
File src/superio/nuvoton/nct668xd/superio.c:
https://review.coreboot.org/c/coreboot/+/34948/7/src/superio/nuvoton/nct668x...
PS7, Line 74: ops_noenable
&ops_noenable
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78eca4ba2948c36a386306887f62773580f6e444
Gerrit-Change-Number: 34948
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Sep 2019 23:37:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment