Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig ......................................................................
Patch Set 51:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35799/38//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35799/38//COMMIT_MSG@21 PS38, Line 21: Tested successfully on X11SSM-F
need to retest after this rework
Done
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/common/block... PS44, Line 347: PRMRR_SIZE
Nit. This Kconfig variable is actually in MiB. […]
IMHO this thing is already long enough... a `grep -r _SIZE src/` showed many Kconfig vars that don't have that and not one that has it
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/common/block... PS44, Line 165: the a
Just 'the'.
Done