1 May
2020
1 May
'20
9:05 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... PS4, Line 2962: slotrank & 0xC
AFAICS, `slotrank` is set to a number from 0 to 3 by FOR_ALL_POPULATED_RANKS. […]
It took me a while to understand "slotrank", but it's just the combination of a slot and a rank.
--
To view, visit https://review.coreboot.org/c/coreboot/+/40721
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9fcc236fbf73f51fe944c6dda5d22ba9d334ec7
Gerrit-Change-Number: 40721
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Kollasch jakllsch@kollasch.net
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 May 2020 21:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment