Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57442 )
Change subject: mb/google/kukui: Add dedicated memory map for kappa
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/kukui/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/57442/comment/a607a587_b5916e97
PS7, Line 59: ,
and its variants
Done
https://review.coreboot.org/c/coreboot/+/57442/comment/e6692cbf_e48b257b
PS7, Line 64: //
A space after //
these remarks should be removed, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97f296cb8c35fd2f979a05d0b97a0562c1b472f3
Gerrit-Change-Number: 57442
Gerrit-PatchSet: 8
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 26 Jan 2022 07:12:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment