Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )
Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32107/3/src/mainboard/asrock/b75pro3-m/Kconf...
File src/mainboard/asrock/b75pro3-m/Kconfig:
https://review.coreboot.org/#/c/32107/3/src/mainboard/asrock/b75pro3-m/Kconf...
PS3, Line 42:
Devicetree says 0x244e and uses 0x1e49 for the LPC bridge. […]
just tagging as resolved
https://review.coreboot.org/#/c/32107/3/src/mainboard/gigabyte/ga-h61m-s2pv/...
File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig:
https://review.coreboot.org/#/c/32107/3/src/mainboard/gigabyte/ga-h61m-s2pv/...
PS3, Line 50:
Devicetree doesn't set it, probably worth to fix?
Scratch that. I just read the comment in autoport, it
was just broken anyway. And these values are likely
autoport generated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72bba8406eea4a264e36cc9bcf467cf5cfbed379
Gerrit-Change-Number: 32107
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Apr 2019 11:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
