Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42608 )
Change subject: mb/up/squared/gpio: 1/3 Decode raw register values
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42608/12/src/mainboard/up/squared/g...
File src/mainboard/up/squared/gpio.h:
https://review.coreboot.org/c/coreboot/+/42608/12/src/mainboard/up/squared/g...
PS12, Line 11: * TODO: check HOSTSW_OWN_{NORTH, NORTHWEST, SOUTHWEST, WEST} to set DRIVER
: * mode for the corresponding pads.
:
todo
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42608
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2523439af8842365c7de901bdfad85ad16d25dcf
Gerrit-Change-Number: 42608
Gerrit-PatchSet: 14
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Jul 2020 11:49:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment