build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: Signed-off-by: Maccraft123 maccraft123mc@gmail.com Change-Id: I4a722382c6f3207388eb27bcc97561609e0de1dd ......................................................................
Patch Set 4:
(14 comments)
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/do... File src/mainboard/lenovo/r60/dock.c:
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/do... PS4, Line 203: udelay(10000); long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/do... PS4, Line 230: udelay(100000); long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/mp... File src/mainboard/lenovo/r60/mptable.c:
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/mp... PS4, Line 42: smp_write_intsrc(mc, mp_ExtINT, \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/mp... PS4, Line 49: smp_write_intsrc(mc, mp_NMI, \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... File src/mainboard/lenovo/r60/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 41: bar = (u8 *)pci_read_config32(PCI_DEV(1, 0, 0), 0x18) trailing whitespace
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 43: printk(BIOS_DEBUG, "bar: %08X, level %02X\n", (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 55: printk(BIOS_DEBUG, "bar: %08X, level %02X\n", (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 126: trailing whitespace
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 131: trailing whitespace
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 136: trailing whitespace
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 139: trailing whitespace
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 142: trailing whitespace
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 147: trailing whitespace
https://review.coreboot.org/c/coreboot/+/35293/4/src/mainboard/lenovo/r60/sm... PS4, Line 165: switch (data) { switch and case should be at the same indent