Attention is currently required from: Furquan Shaikh, Dtrain Hsu, Henry Sun, Tim Wawrzynczak.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54057 )
Change subject: mb/google/dedede/var/cret: Enable/disable LTE function based on FW_CONFIG
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/dedede/variants/cret/variant.c:
https://review.coreboot.org/c/coreboot/+/54057/comment/e60f0a4d_d90de44d
PS3, Line 18: Once the FW_CONFIG is provisioned,
I know it is not the most ideal thing, but is there any harm in calling `power_off_lte_module()` unc […]
I am fine with that since we will be in S5 for only 10 seconds before entering G3 and hence power leakage should not be that bad on non-LTE designs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib926e99aaf9df433a7cff71180ee55431d69f718
Gerrit-Change-Number: 54057
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 14 May 2021 23:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment