[coreboot-gerrit] Change in coreboot[master]: nb/via/vx900: Ensure framebuffer size is within limits

[Jacob Garber (Code Review)]

Hello Kyösti Mälkki, Angel Pons, David Hendricks, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34355

to look at the new patch set (#4).

Change subject: nb/via/vx900: Ensure framebuffer size is within limits
......................................................................

nb/via/vx900: Ensure framebuffer size is within limits

- Do a sanity check that size_mb is nonzero, else fb_pow will be
  negative, leading to an undefined integer shift. Rewrite the loop
  as a do-while to make clear that no underflow can happen now.
- Use an unsigned integer when calculating 1U << fb_pow.
- The framebuffer size needs to be between 8 and 512 MiB, so check
  after all the calculations are done to make sure this is the case.

Change-Id: I3962e5cdc094c8da22d8dbadf16637e02fa98689
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1391086
---
M src/northbridge/via/vx900/memmap.c
1 file changed, 11 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/34355/4