build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30432 )
Change subject: drivers/smmstore: Fix some issues ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c File src/drivers/smmstore/store.c:
https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@188 PS8, Line 188: if (boot_device_rw_subregion(region_device_region(&store), &store) < 0) { line over 80 characters
https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@195 PS8, Line 195: .size = sizeof(key_sz) + sizeof(value_sz) + key_sz + value_sz + sizeof(nul), line over 80 characters
https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@203 PS8, Line 203: if (rdev_writeat(&store, &key_sz, end, sizeof(key_sz)) != sizeof(key_sz)) { line over 80 characters
https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@208 PS8, Line 208: if (rdev_writeat(&store, &value_sz, end, sizeof(value_sz)) != sizeof(key_sz)) { line over 80 characters