build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30432 ) Change subject: drivers/smmstore: Fix some issues ...................................................................... Patch Set 8: (4 comments) https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c File src/drivers/smmstore/store.c: https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@188 PS8, Line 188: if (boot_device_rw_subregion(region_device_region(&store), &store) < 0) { line over 80 characters https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@195 PS8, Line 195: .size = sizeof(key_sz) + sizeof(value_sz) + key_sz + value_sz + sizeof(nul), line over 80 characters https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@203 PS8, Line 203: if (rdev_writeat(&store, &key_sz, end, sizeof(key_sz)) != sizeof(key_sz)) { line over 80 characters https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@208 PS8, Line 208: if (rdev_writeat(&store, &value_sz, end, sizeof(value_sz)) != sizeof(key_sz)) { line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/30432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I629be25d2a9b65796ae8f7a700b6bdab57b91b22 Gerrit-Change-Number: 30432 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Matthew Garrett <mjg59@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 29 May 2019 16:57:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment