Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33160 )
Change subject: qcs405: Add board_config entry in the interface table ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33160/8/src/soc/qualcomm/qcs405/soc... File src/soc/qualcomm/qcs405/soc_blob_load.c:
https://review.coreboot.org/c/coreboot/+/33160/8/src/soc/qualcomm/qcs405/soc... PS8, Line 30: } qcs405_board_config; Just define this as a pointer:
struct board_config { ... } *qcs405_board_config = (void *)_board_config;
And then you can do
qcs405_board_config->buck_type = buck_type;
below which looks nicer.
https://review.coreboot.org/c/coreboot/+/33160/8/src/soc/qualcomm/qcs405/soc... PS8, Line 36: qcs405_board_config.buck_type = int_buck; Sorry, this code also needs to go in the mainboard. board_id() is completely mainboard-specific. qclib_set_buck_type() should take an enum buck_type parameter.