Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46401 )
Change subject: soc/mediatek/mt8192: Reserve 44K SRAM for MPUPM working buffer
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46401/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46401/4//COMMIT_MSG@7
PS4, Line 7: Reserved
Imperative mood: Reserve.
Ack
https://review.coreboot.org/c/coreboot/+/46401/1/src/soc/mediatek/mt8192/inc...
File src/soc/mediatek/mt8192/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/46401/1/src/soc/mediatek/mt8192/inc...
PS1, Line 29: SRAM_END(0x00115000)
The SRAM_END should be indicating real end of SRAM. […]
Ack.
The address used by MPUPM is fixed (0x00115000 ~ 0x0011ffff).
Add a reserved region at the end of SRAM.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46401
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic82a194736eecd7bdc8df80b493290090a2ccba5
Gerrit-Change-Number: 46401
Gerrit-PatchSet: 15
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 29 Oct 2020 12:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment