Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37793 )
Change subject: soc/intel/common: Add GPIO PM configuration into NVS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37793/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/nvs.h:
https://review.coreboot.org/c/coreboot/+/37793/1/src/soc/intel/common/block/...
PS1, Line 43: u8 gpmv[TOTAL_GPIO_COMM]; /* 0x31 - GPIO PM Value */
: u8 unused[202];
yes, if TOTAL_GPIO_COMM > 5 then check_number would assert. […]
Looks OK.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37793
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4f950d97c7d1dbe22f6e57cd502afde6935d831
Gerrit-Change-Number: 37793
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Dec 2019 18:29:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment