Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39446 )
Change subject: mb/google/dedede: Add BT Disable GPIO configuration
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39446/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39446/2/src/mainboard/google/dedede...
PS2, Line 414: PAD_CFG_GPO(GPP_H19, 0, DEEP),
I don't think it needs to be configured in bootblock. I just meant to enable the reset when configuring GPIOs, and then let the kernel drive the reset as it wants to.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc
Gerrit-Change-Number: 39446
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Mar 2020 14:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment