Attention is currently required from: Felix Singer, Jan Samek.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75078?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/siemens: Move selects from Kconfig.name to Kconfig ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/mainboard/siemens/mc_apl1/Kconfig:
https://review.coreboot.org/c/coreboot/+/75078/comment/551b0e53_dcd3d996 : PS5, Line 10: config BOARD_SIEMENS_MC_APL1 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL2 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL3 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL4 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL5 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL6 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL7 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 Isn't it then perhaps better to select _BASEBOARD_ in variant/../Kconfig?