Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47390 )
Change subject: mb/google/volteer/variant/lindar: Update devicetree settings ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47390/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47390/1//COMMIT_MSG@6 PS1, Line 6: : mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad : : Update I2C address for Goodix touchscreen and add ELAN touchscreen & Synaptics trackpad. : : BUG=b:160013582 : TEST=emerge-puff coreboot and check system dmesg and evtest can get device.
Please keep all lines to 72 characters. […]
Done
https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG@8 PS3, Line 8: touchscreen and trackpad
drop this line, commit summary should be 72 chars or less
Done
https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG@15 PS3, Line 15: puff
emerge-volteer
Done
https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... PS1, Line 66: EDGE
LEVEL, see CB:47415
Modify Line:45 as LEVEL instead of Line:66.
https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... PS1, Line 88: EDGE
LEVEL, see CB:47415
Done