build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39615 )
Change subject: sc7180: Add display hardware pipe line initialization
......................................................................
Patch Set 22:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39615/22/src/mainboard/google/trogd...
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39615/22/src/mainboard/google/trogd...
PS22, Line 94: if(ret)
space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39615/22/src/mainboard/google/trogd...
PS22, Line 119: return ;
space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/39615/22/src/mainboard/google/trogd...
PS22, Line 129: else
else should follow close brace '}'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39615
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d5e3f1781c48759553243abeb3d694f76cd008e
Gerrit-Change-Number: 39615
Gerrit-PatchSet: 22
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 30 Jun 2020 05:06:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment