22 May
2023
22 May
'23
1:34 a.m.
Attention is currently required from: Van Chen, Tarun Tuli, Dtrain Hsu, Subrata Banik, Paul Menzel, Shou-Chieh Hsu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75335 )
Change subject: mb/google/nissa/var/uldren: Add fw_config probe for touchscreen ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/uldren/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75335/comment/e6fb16a3_b1784555 PS2, Line 3: TOUCHSCREEN_UNKNOW Wasn't it supposed to be TOUCHSCREEN_UNKNOWN (with N at the end)?
--
To view, visit https://review.coreboot.org/c/coreboot/+/75335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d8129b3af3aa09e5bc31160de82d9ef7af0dd59
Gerrit-Change-Number: 75335
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-CC: Jakub Czapiga jacz@semihalf.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Comment-Date: Mon, 22 May 2023 06:34:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment