[coreboot-gerrit] Change in coreboot[master]: soc/intel/graphics: Create Kconfig for shifting graphic memory base

[Ethan Tsao (Code Review)]

Attention is currently required from: Subrata Banik, Nico Huber, Wonkyu Kim, Ravishankar Sarawadi, Tim Wawrzynczak, Paul Menzel, Raj Astekar, Patrick Rudolph.
Ethan Tsao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61389 )

Change subject: soc/intel/graphics: Create Kconfig for shifting graphic memory base
......................................................................

Patch Set 13:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/61389/comment/49076ea5_67b50ea3 
PS11, Line 7: soc/intel/graphics: Create Kconfig for shifting graphic memory base
> > > Also, may be something like SOC_INTEL_GFX_GMADR_BEHIND_GTT could be your parent Kconfig which de […]

Done

https://review.coreboot.org/c/coreboot/+/61389/comment/af1ac7f5_03d0a2ef 
PS11, Line 9: create SOC_INTEL_GFX_MEMBASE_OFFSET for platform to
            : shift graphic memory base if require.
> 72 characters wide please

Done

https://review.coreboot.org/c/coreboot/+/61389/comment/f796a017_86962f04 
PS11, Line 10: require
> `required`

Done

File src/soc/intel/common/block/graphics/graphics.c:

https://review.coreboot.org/c/coreboot/+/61389/comment/a5b6d1bb_d54858b1 
PS11, Line 122: 	printk(BIOS_INFO, "gfx memory bar(0x18) = 0x%lx GFX_MEMBASE_OFFSET = 0x%x\n",
              : 		memory_base, CONFIG_SOC_INTEL_GFX_MEMBASE_OFFSET);
> Can we also print out final memory_base? […]

This message is show 1 time during boot.

https://review.coreboot.org/c/coreboot/+/61389/comment/ce7139ba_e292f6b8 
PS11, Line 129: memory_base = memory_base + CONFIG_SOC_INTEL_GFX_MEMBASE_OFFSET;
> I also think above memory_base checking for checking PCI config space 0x18 is programmed or not.

Done