Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support with interface tables
......................................................................
Patch Set 33:
(1 comment)
We are working on fixing this. In the meantime we did not want the patch train to fail becasue of this change, so we will fix this issue and push it.
https://review.coreboot.org/c/coreboot/+/29967/30/src/mainboard/google/mistr...
File src/mainboard/google/mistral/romstage.c:
https://review.coreboot.org/c/coreboot/+/29967/30/src/mainboard/google/mistr...
PS30, Line 32: qclib_load_and_run();
Done
Hi Julius/Patrick,
Making the qclib_load_and_run() as the last call, results in failure of enabling USB related clocks in QCLIB and gets stuck there as the prepare_usb() function does a core reset.
So we are working on fixing it and will be addressed in the next push.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 33
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Thu, 11 Jul 2019 05:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment