Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
lots of magic, but it is what it is. Mostly some comments on the comments...
https://review.coreboot.org/c/coreboot/+/40721/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40721/1//COMMIT_MSG@13 PS1, Line 13: srubbing nit: scrubbing
https://review.coreboot.org/c/coreboot/+/40721/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/40721/1/src/northbridge/intel/sandy... PS1, Line 377: /* Test ECC in normal mode! */ what's that comment supposed to mean? Maybe "can't do this earlier because it needs to be done in normal operation"?
https://review.coreboot.org/c/coreboot/+/40721/1/src/northbridge/intel/sandy... PS1, Line 386: i = 1; This skips the entire first megabyte, right? Maybe change the comment to "Test up to TSEG. Skip first MB to avoid special case for A-seg"?
https://review.coreboot.org/c/coreboot/+/40721/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/1/src/northbridge/intel/sandy... PS1, Line 2969: oberservation nit: observation