[coreboot-gerrit] New patch to review for coreboot: 631e5c8 Jetway NF81-T56N-LF: Serialize ACPI method remarks to avoid race-conditions.

[Edward O'Callaghan]

Edward O'Callaghan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5079

-gerrit

commit 631e5c853881b66ddd89ac536e382aa889a07e6d
Author: Edward O'Callaghan 
Date:   Wed Jan 29 15:29:44 2014 +1100

Jetway NF81-T56N-LF: Serialize ACPI method remarks to avoid race-conditions.

Fix the remark introduced in ACPICA version 20130517 that gives the
    following explanation:

If a thread blocks within the method for any reason, and another thread
            enters the method, the method will fail because an attempt will be
            made to create the same (named) object twice.

In this case, issue a remark that the method should be marked
            serialized. ACPICA BZ 909.

The toolchain remarks fixed by this are as follows:

Intel ACPI Component Architecture
    ASL Optimizing Compiler version 20130626-64 [Jan 26 2014]
    Copyright (c) 2000 - 2013 Intel Corporation

dsdt.ramstage.asl   1034:  Method(_GTM, 0)
    Remark   2120 -                     ^ Control Method should be made Serialized (due to creation of named objects within)

dsdt.ramstage.asl   1069:  Method(_STM, 3, NotSerialized)
    Remark   2120 -                     ^ Control Method should be made Serialized (due to creation of named objects within)

dsdt.ramstage.asl   1114:   Method(_GTF) {
    Remark   2120 -                      ^ Control Method should be made Serialized (due to creation of named objects within)

dsdt.ramstage.asl   1146:   Method(_GTF) {
    Remark   2120 -                      ^ Control Method should be made Serialized (due to creation of named objects within)

ASL Input:     dsdt.ramstage.asl - 1732 lines, 33264 bytes, 941 keywords
    AML Output:    dsdt.ramstage.aml - 10152 bytes, 406 named objects, 535 executable opcodes
    Hex Dump:      dsdt.ramstage.hex - 95502 bytes

Change-Id: I2b3605a31a8647c07be0830e54cd117d53985c81
    Signed-off-by: Edward O'Callaghan 
---
 src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
index b3aed9c..4071f85 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
+++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/ide.asl
@@ -77,7 +77,7 @@ Method(GTTM, 1) /* get total time*/
 Device(PRID)
 {
    Name (_ADR, Zero)
-	Method(_GTM, 0)
+	Method(_GTM, 0, Serialized)
    {
    	NAME(OTBF, Buffer(20) { /* out buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -122,7 +122,7 @@ Device(PRID)
    	Return(OTBF) /* out buffer */
    }				/* End Method(_GTM) */

-	Method(_STM, 3, NotSerialized)
+	Method(_STM, 3, Serialized)
    {
    	NAME(INBF, Buffer(20) { /* in buffer */
    		0xFF, 0xFF, 0xFF, 0xFF,
@@ -173,7 +173,7 @@ Device(PRID)
    Device(MST)
    {
    	Name(_ADR, 0)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
@@ -209,7 +209,7 @@ Device(PRID)
    Device(SLAV)
    {
    	Name(_ADR, 1)
-		Method(_GTF) {
+		Method(_GTF, 0, Serialized) {
    		Name(CMBF, Buffer(21) {
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,
    			0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,