Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38738 )
Change subject: mb/google/dedede: Add Compute & PCH Global device IDs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38738/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38738/1/src/mainboard/google/dedede...
PS1, Line 7: device pci 00.0 off end # Host Bridge
The code is indented using tabs - both in the new one and the existing block. […]
I looked at other devicetrees as well. Tabs are used at the start of the line for indentation. After that only spaces are used. Hence marking the comment as resolved. Please feel free to re-open the comment if I missed something.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f226abd52d4a27535de6711e93355b5f84a1941
Gerrit-Change-Number: 38738
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Feb 2020 00:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment