Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40234 )
Change subject: drivers/ipmi: Add IPMI KCS support in romstage ......................................................................
Patch Set 2:
(2 comments)
looks good, thanks. just some minor style nits
https://review.coreboot.org/c/coreboot/+/40234/2/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops_premem.c:
https://review.coreboot.org/c/coreboot/+/40234/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 1: * : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ please update license header to new SPDX format
https://review.coreboot.org/c/coreboot/+/40234/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 16: nit: why blank like here? I don't think it is needed