build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43567 )
Change subject: mb/51nb/x210/gpio: 2/4 Exclude fields for PAD_CFG ......................................................................
Patch Set 4:
(23 comments)
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... File src/mainboard/51nb/x210/gpio.h:
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 40: /* GPIO */_PAD_CFG_STRUCT(GPP_B3, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 47: /* GPIO */_PAD_CFG_STRUCT(GPP_B10, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 53: /* GPIO */_PAD_CFG_STRUCT(GPP_B16, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 54: /* GPIO */_PAD_CFG_STRUCT(GPP_B17, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 55: /* GPIO */_PAD_CFG_STRUCT(GPP_B18, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 66: /* GPIO */_PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(20K_PD)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 94: /* GPIO */_PAD_CFG_STRUCT(GPP_D9, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 95: /* GPIO */_PAD_CFG_STRUCT(GPP_D10, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 96: /* GPIO */_PAD_CFG_STRUCT(GPP_D11, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 97: /* GPIO */_PAD_CFG_STRUCT(GPP_D12, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 110: /* GPIO */_PAD_CFG_STRUCT(GPP_E1, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 112: /* GPIO */_PAD_CFG_STRUCT(GPP_E3, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 124: /* GPIO */_PAD_CFG_STRUCT(GPP_E15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_IRQ_ROUTE(SCI) | PAD_RX_POL(INVERT) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 125: /* GPIO */_PAD_CFG_STRUCT(GPP_E16, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 149: /* SATAXPCIE7 */_PAD_CFG_STRUCT(GPP_F4, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_CFG1_TOL_1V8 | PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 150: /* SATA_DEVSLP3 */_PAD_CFG_STRUCT(GPP_F5, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_CFG1_TOL_1V8 | PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 151: /* SATA_DEVSLP4 */_PAD_CFG_STRUCT(GPP_F6, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_CFG1_TOL_1V8 | PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 152: /* SATA_DEVSLP5 */_PAD_CFG_STRUCT(GPP_F7, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_CFG1_TOL_1V8 | PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 153: /* SATA_DEVSLP6 */_PAD_CFG_STRUCT(GPP_F8, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_CFG1_TOL_1V8 | PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 154: /* SATA_DEVSLP7 */_PAD_CFG_STRUCT(GPP_F9, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_CFG1_TOL_1V8 | PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 155: /* n/a */_PAD_CFG_STRUCT(GPP_F10, PAD_FUNC(NF2) | PAD_RESET(DEEP), PAD_CFG1_TOL_1V8 | PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 156: /* n/a */_PAD_CFG_STRUCT(GPP_F11, PAD_FUNC(NF2) | PAD_RESET(DEEP), PAD_CFG1_TOL_1V8 | PAD_PULL(20K_PU)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43567/4/src/mainboard/51nb/x210/gpi... PS4, Line 168: /* GPIO */_PAD_CFG_STRUCT(GPP_F23, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters