Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40244 )
Change subject: soc/tigerlake: Add devicetree configurability for IomTypeCPortPadCfg
......................................................................
Patch Set 3:
(3 comments)
all comments were already addressed just didn't mark them resolved all are resolved
https://review.coreboot.org/c/coreboot/+/40244/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40244/2//COMMIT_MSG@10
PS2, Line 10: retimer
nit - Please add a comma after "retimer,"
Ack
https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/chi...
PS1, Line 234: 8
this is 8 wide due to there being 2 fields for each type C port. […]
Ack
https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/fsp...
PS1, Line 98: 0x09000000
SG
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40244
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e48adb624c7922170eafb8dfcaed680f008936e
Gerrit-Change-Number: 40244
Gerrit-PatchSet: 3
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 May 2020 22:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment