[coreboot-gerrit] Change in coreboot[master]: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )

Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................

Patch Set 72:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... 
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... 
PS68, Line 28: register "SkipExtGfxScan" = "1"
> Will the video also be output to Aspeed VGA If I install an external graphics card in the PEG port?

No, as the aspeed VGA is assumed to be "onboard" as it's part of the devicetree and coreboot will disable onboard VGA if an external GPU is present. But that's unrelated to SkipExtGfxScan.

https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... 
PS68, Line 153: .icc_max = 0x1C
> That should be 0 as src/soc/intel/skylake/vr_config.c should handle replaceable CPUs. […]

Done