Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37822 )
Change subject: mainboard/google/puff: Don't enable MAX98357A in dt ......................................................................
Patch Set 7:
Patch Set 7:
(1 comment)
Patch Set 7:
(1 comment)
Patch Set 7:
(1 comment)
CB:37909 undoes what is done in this CL. Can we just drop this?
This fixes an immediate issue while the follow up is the proposed 'proper fix' which is more invasive. As I explained to Dan already, here we fix the issue while in the follow up we propose the more long term maintainable strategy on detailing with the current assumptions in baseboard.
Understood. But, both changes are going to effectively land at the same time and since you already have a solution in CB:37909 which is right long term fix, having this separate short-lived change seems unnecessary.
More than happy to drop the short term fix for the long term refactor that fixes the issue provided you are happy with the invasiveness. I am just trying to get the issues fixes while at the same time put effort into making things cleaner for the long term.