Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47287 )
Change subject: WIP: load spm firmware from cbfs ......................................................................
Patch Set 6:
(13 comments)
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/spm.h:
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/inc... PS6, Line 673: Remove extra blank line.
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 487: struct const
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 496: Remove the space.
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 515: write32(&mtk_spm->md32pcm_dma0_start, MD32PCM_DMA0_START_VAL);
Sorry, comment belong in https://review.coreboot. […]
Ack
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 546: copy_size Use type size_t
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 570: 0x%x %#x
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 573: 16 copy_size
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 581: struct pcm_desc pcm->desc
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 582: (void *) No need for the casting.
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 582: &(pcm->desc.pmem_words) Simply &pcm->desc
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 587: spmfw version = %s and is spmfw (version %s)
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 588: ( Remove the parentheses.
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 709: 0x%x %#x