Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: soc/intel: Add Intel Xeon Scalable Processor support ......................................................................
Patch Set 45:
(2 comments)
Thanks for the review!
https://review.coreboot.org/c/coreboot/+/38548/45/src/soc/intel/xeon_sp/Kcon... File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/38548/45/src/soc/intel/xeon_sp/Kcon... PS45, Line 87: string
In order fort his to show up in menuconfig, this needs to have a value. So perhaps: […]
Done
https://review.coreboot.org/c/coreboot/+/38548/45/src/soc/intel/xeon_sp/incl... File src/soc/intel/xeon_sp/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/38548/45/src/soc/intel/xeon_sp/incl... PS45, Line 25: void
I don't think mainboard_config_gpios() is called directly outside of the mainboard's own romstage. […]
Done