Attention is currently required from: Hung-Te Lin, Ruihai Zhou.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78957?usp=email )
Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/geralt/panel_ciri.c:
https://review.coreboot.org/c/coreboot/+/78957/comment/9e1fbd1c_8d0ce762 :
PS9, Line 17: power_on_mipi_boe_tv110wum_ll0
The register PMIC_TPS65132_DLYX is different for power sequence requirment. […]
Sounds good. You can do like this to keep `.power_on` prototype.
```
static void power_on_mipi_boe_tv110wum_ll0(void)
{
const struct tps65132s_cfg cfg = {
...
};
power_on_mipi_panel(&cfg);
}
static struct panel_description ciri_panels[] = {
...
.power_on = power_on_mipi_boe_tv110wum_ll0,
};
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78957?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9
Gerrit-Change-Number: 78957
Gerrit-PatchSet: 9
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 09 Jan 2024 10:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment